Page MenuHomePhabricator

When users edit recurring events, prompt to "Edit This Event" or "Edit All Future Events"
ClosedPublic

Authored by epriestley on Oct 31 2016, 10:18 PM.

Details

Summary

Fixes T11804. This probably isn't perfect but seems to work fairly reasonably and not be as much of a weird nonsense mess like the old behavior was.

When a user edits a recurring event, we ask them what they're trying to do. Then we more or less do that.

Test Plan
  • Edited an event in the middle of a series.
  • Edited the first event in a series.
  • Edited "just this" and "all future" events in various places in a series.
  • Edited normal events.
  • Cancelled various events.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to When users edit recurring events, prompt to "Edit This Event" or "Edit All Future Events".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix "seires" typo.
chad accepted this revision.Oct 31 2016, 11:01 PM
chad edited edge metadata.

tldr;

This revision is now accepted and ready to land.Oct 31 2016, 11:01 PM
chad accepted this revision.Oct 31 2016, 11:01 PM

tldr;

chad added a comment.Oct 31 2016, 11:02 PM

i mean, I didn't see stealCorporateSecrets or anything

This revision was automatically updated to reflect the committed changes.