Page MenuHomePhabricator
Differential D16769

Fix a variant translation issue
ClosedPublic
Actions

Authored by epriestley on Oct 30 2016, 12:01 AM.
Tags
None
Referenced Files
F15430249: D16769.id40388.diff
Mon, Mar 24, 6:44 AM
F15420600: D16769.id40388.diff
Fri, Mar 21, 3:19 PM
F15416132: D16769.id40388.diff
Thu, Mar 20, 9:28 AM
F15414276: D16769.id.diff
Wed, Mar 19, 11:53 PM
F15413749: D16769.id40387.diff
Wed, Mar 19, 9:05 PM
F15407994: D16769.diff
Tue, Mar 18, 8:43 PM
F15390395: D16769.id40388.diff
Sat, Mar 15, 6:10 AM
F15387585: D16769.id40387.diff
Sat, Mar 15, 2:39 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11799: Garbage tool complains about invalid translation on 'set-policy' command
Commits
rP199300565142: Fix a variant translation issue
Summary

Fixes T11799. This string is varying on the first parameter, but should vary on the second parameter.

Test Plan

Ran bin/garbage set-policy ..., saw proper translation.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40387.Oct 30 2016, 12:01 AM
epriestley retitled this revision from to Fix a variant translation issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this object.Oct 30 2016, 12:01 AM
epriestley added a task: T11799: Garbage tool complains about invalid translation on 'set-policy' command.
chad accepted this revision.Oct 30 2016, 12:12 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2016, 12:12 AM
Closed by commit rP199300565142: Fix a variant translation issue (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2016, 12:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
internationalization/
translation/
6 lines

Diff 40388

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility