Page MenuHomePhabricator

Make event invitees behave a little better for stub/ghost events
ClosedPublic

Authored by epriestley on Oct 27 2016, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:20 PM
Unknown Object (File)
Wed, Dec 11, 6:36 AM
Unknown Object (File)
Mon, Dec 9, 12:21 AM
Unknown Object (File)
Sun, Dec 8, 5:05 AM
Unknown Object (File)
Wed, Dec 4, 5:41 AM
Unknown Object (File)
Tue, Dec 3, 11:49 PM
Unknown Object (File)
Tue, Dec 3, 11:49 PM
Unknown Object (File)
Tue, Dec 3, 11:23 PM
Subscribers
None

Details

Summary

Ref T11326. Currently:

  • The month view and day view (ghosts) don't show that you're invited to a child event.
  • The detail view copies the invite list, including attending status, but only after it shows the page for the first time.

Instead, for now, just do this:

  • Ghosts/stubs use the parent invite list, but treat everyone as "invited".
  • Materializing a stub just saves the list as-is (i.e., invited, not a copy of attending/declined/etc).

This behavior may need some refining eventually but is at least reasonable (not obviously bad/buggy).

Test Plan
  • Viewed month/day views, now shown as "invited".
  • Viewed detail view, now invitee list shows up properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make event invitees behave a little better for stub/ghost events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2016, 6:26 PM
This revision was automatically updated to reflect the committed changes.