Page MenuHomePhabricator

Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription
ClosedPublic

Authored by epriestley on Oct 26 2016, 10:51 PM.
Tags
None
Referenced Files
F15485385: D16757.diff
Wed, Apr 9, 11:22 PM
F15483791: D16757.id40360.diff
Wed, Apr 9, 2:27 PM
F15478426: D16757.id.diff
Mon, Apr 7, 11:15 PM
F15477322: D16757.id40359.diff
Mon, Apr 7, 1:27 PM
F15475577: D16757.diff
Sun, Apr 6, 8:55 PM
F15404732: D16757.diff
Mar 18 2025, 8:47 AM
F15383926: D16757.diff
Mar 14 2025, 6:20 PM
F15383655: D16757.id40359.diff
Mar 14 2025, 5:29 PM
Subscribers
None

Details

Summary

A live instance hit the scenario described in the comment, where an out-of-date user was being selected as the actor.

Since they were no longer an account member, they could not see the payment method and autopay was failing.

Instead, select a relatively arbitrary user who is a current, valid, non-disabled member.

Test Plan

Ran subscriptions with bin/worker execute ..., saw it select a valid actor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 10:53 PM
This revision was automatically updated to reflect the committed changes.