Page MenuHomePhabricator

Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription
ClosedPublic

Authored by epriestley on Oct 26 2016, 10:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 3:09 PM
Unknown Object (File)
Wed, Nov 27, 11:10 AM
Unknown Object (File)
Sat, Nov 23, 3:48 PM
Unknown Object (File)
Tue, Nov 19, 5:50 AM
Unknown Object (File)
Nov 15 2024, 1:59 PM
Unknown Object (File)
Nov 10 2024, 10:12 PM
Unknown Object (File)
Nov 7 2024, 3:15 AM
Unknown Object (File)
Oct 25 2024, 11:19 AM
Subscribers
None

Details

Summary

A live instance hit the scenario described in the comment, where an out-of-date user was being selected as the actor.

Since they were no longer an account member, they could not see the payment method and autopay was failing.

Instead, select a relatively arbitrary user who is a current, valid, non-disabled member.

Test Plan

Ran subscriptions with bin/worker execute ..., saw it select a valid actor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Phortune bug where an invalid viewer could sometimes be selected for billing a subscription.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2016, 10:53 PM
This revision was automatically updated to reflect the committed changes.