Page MenuHomePhabricator
Differential D16688

Provide start/end date time via Conduit for Calendar
ClosedPublic
Actions

Authored by epriestley on Oct 11 2016, 6:55 PM.
Tags
None
Referenced Files
F15474029: D16688.id40176.diff
Sun, Apr 6, 4:26 AM
F15459766: D16688.id.diff
Mon, Mar 31, 4:07 PM
F15457573: D16688.id40177.diff
Sun, Mar 30, 5:17 PM
F15457572: D16688.id40176.diff
Sun, Mar 30, 5:17 PM
F15446045: D16688.id40177.diff
Thu, Mar 27, 4:55 PM
F15446044: D16688.id40176.diff
Thu, Mar 27, 4:55 PM
F15446043: D16688.id.diff
Thu, Mar 27, 4:55 PM
F15442642: D16688.diff
Wed, Mar 26, 11:53 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11706: Retrieve event date from Calendar "calendar.event.search" method API
Commits
rPd79972ecb3a2: Provide start/end date time via Conduit for Calendar
Summary

Fixes T11706. I think this approach (roughly: provide the information in a few different formats) is generally reasonable, and should let clients choose how much date/time magic they want to do.

Test Plan

Called calenadar.event.search, viewed results.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/calendar/storage/PhabricatorCalendarEvent.php:1094XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14069
Build 18252: Run Core Tests
Build 18251: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40176.Oct 11 2016, 6:55 PM
epriestley retitled this revision from to Provide start/end date time via Conduit for Calendar.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11706: Retrieve event date from Calendar "calendar.event.search" method API.
chad accepted this revision.Oct 11 2016, 7:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 11 2016, 7:01 PM
Closed by commit rPd79972ecb3a2: Provide start/end date time via Conduit for Calendar (authored by epriestley, committed by epriestley). · Explain WhyOct 11 2016, 7:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
storage/
36 lines

Diff 40176

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility