Differential D16666

Add Room Image to Conpherence header
ClosedPublic
Actions

Authored by chad on Oct 4 2016, 11:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 8:59 PM

	Unknown Object (File)
	Tue, Dec 3, 6:00 AM

	Unknown Object (File)
	Tue, Nov 26, 2:05 PM

	Unknown Object (File)
	Tue, Nov 26, 2:05 PM

	Unknown Object (File)
	Tue, Nov 26, 2:04 PM

	Unknown Object (File)
	Tue, Nov 26, 1:46 PM

	Unknown Object (File)
	Tue, Nov 26, 7:29 AM

	Unknown Object (File)
	Sat, Nov 23, 11:49 PM

Subscribers

Details

Reviewers

Commits

rP02b5a2b39b79: Add Room Image to Conpherence header

Summary

This adds the room image to the main header in full Conpherence. It's nice, plus I plan to move the image edit workflow to it to simplify the move to EditEngine. I plan to build some default images for Conpherence which should be better about denoting the room, not just the last person writing.

Test Plan

Click on lots of rooms with and without topics.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40120.Oct 4 2016, 11:18 PM

chad retitled this revision from to Add Room Image to Conpherence header.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 4 2016, 11:18 PM

epriestley accepted this revision.Oct 4 2016, 11:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 4 2016, 11:23 PM

Closed by commit rP02b5a2b39b79: Add Room Image to Conpherence header (authored by chad, committed by chad). · Explain WhyOct 4 2016, 11:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

applications/

conpherence/

controller/

ConpherenceController.php

2 lines

webroot/

rsrc/

css/

application/

conpherence/

header-pane.css

21 lines

Diff 40121

resources/celerity/map.php

Loading...

src/applications/conpherence/controller/ConpherenceController.php

Loading...

webroot/rsrc/css/application/conpherence/header-pane.css

Loading...