Differential D16647

Add an icon to aphlict connection status
ClosedPublic
Actions

Authored by chad on Oct 2 2016, 3:35 AM.

Tags

None

Referenced Files

	F13142693: D16647.diff
	Fri, May 3, 6:35 AM

	Unknown Object (File)
	Thu, Apr 25, 1:01 AM

	Unknown Object (File)
	Sun, Apr 14, 10:56 AM

	Unknown Object (File)
	Tue, Apr 9, 11:12 AM

	Unknown Object (File)
	Mon, Apr 8, 10:25 AM

	Unknown Object (File)
	Feb 14 2024, 10:52 PM

	Unknown Object (File)
	Feb 14 2024, 10:52 PM

	Unknown Object (File)
	Feb 14 2024, 4:10 PM

Subscribers

Details

Reviewers

Commits

rPa591b86d910b: Add an icon to aphlict connection status

Summary

A bit better styling, this adds an indication icon for if you're connected or not (and later, away, etc).

Test Plan

Test in Notifications menu, Conpherence full, Durable Column.

Diff Detail

Repository

Branch

connection-dots (branched from master)

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/notification/view/PhabricatorNotificationStatusView.php:22	XHP48	Array Separator
Advice	src/applications/notification/view/PhabricatorNotificationStatusView.php:25	XHP48	Array Separator
Advice	src/applications/notification/view/PhabricatorNotificationStatusView.php:28	XHP48	Array Separator

Unit

Tests Passed

Build Status

Buildable 13968
Build 18097: Run Core Tests
Build 18096: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40077.Oct 2 2016, 3:35 AM

chad retitled this revision from to Add an icon to aphlict connection status.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptOct 2 2016, 3:35 AM

lint x 2

epriestley accepted this revision.Oct 2 2016, 11:21 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 2 2016, 11:21 AM

Closed by commit rPa591b86d910b: Add an icon to aphlict connection status (authored by chad, committed by chad). · Explain WhyOct 2 2016, 3:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

28 lines

src/

applications/

conpherence/

view/

ConpherenceDurableColumnView.php

3 lines

notification/

view/

PhabricatorNotificationStatusView.php

39 lines

webroot/

rsrc/

css/

application/

base/

notification-menu.css

14 lines

conpherence/

durable-column.css

18 lines

js/

application/

aphlict/

behavior-aphlict-status.js

12 lines

Diff 40077

resources/celerity/map.php

Loading...

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...

src/applications/notification/view/PhabricatorNotificationStatusView.php

Loading...

webroot/rsrc/css/application/base/notification-menu.css

Loading...

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...

webroot/rsrc/js/application/aphlict/behavior-aphlict-status.js

Loading...