Page MenuHomePhabricator

Group similar transaction comments in Conpherence
ClosedPublic

Authored by chad on Sep 29 2016, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 20, 9:44 PM
Unknown Object (File)
Sat, Jan 14, 11:42 PM
Unknown Object (File)
Wed, Jan 11, 9:29 PM
Unknown Object (File)
Wed, Jan 11, 5:58 PM
Unknown Object (File)
Wed, Jan 11, 5:58 PM
Unknown Object (File)
Sat, Jan 7, 10:59 PM
Unknown Object (File)
Thu, Jan 5, 5:31 AM
Unknown Object (File)
Sat, Dec 31, 3:07 PM
Subscribers
Tokens
"Party Time" token, awarded by scp.

Details

Summary

Adds a CSS class if comments come in from the same user in the past 2 minutes for cleaner UI. Note will have to find some better display UI when comment editing comes.

Test Plan

Test lots of random Conpherence messages with different transactions, different people, and quick commenting.

Diff Detail

Repository
rP Phabricator
Branch
group-transactions (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13928
Build 18037: Run Core Tests
Build 18036: arc lint + arc unit

Event Timeline

chad retitled this revision from to Group similar transaction comments in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, scp.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 7:21 PM
This revision was automatically updated to reflect the committed changes.

@scp you still owe us one. I didn't use your "hax"