Page MenuHomePhabricator
Differential D16632

Group similar transaction comments in Conpherence
ClosedPublic
Actions

Authored by chad on Sep 29 2016, 7:20 PM.
Tags
None
Referenced Files
F18904822: D16632.id40040.diff
Sat, Nov 8, 11:15 AM
F18851587: D16632.id40039.diff
Fri, Oct 31, 2:22 AM
F18839851: D16632.diff
Mon, Oct 27, 7:19 PM
F18791062: D16632.id.diff
Thu, Oct 16, 12:14 AM
F18788994: D16632.id40039.diff
Wed, Oct 15, 7:27 AM
F18782746: D16632.id.diff
Mon, Oct 13, 2:31 AM
F18778450: D16632.id40040.diff
Sat, Oct 11, 9:30 AM
F18778419: D16632.diff
Sat, Oct 11, 9:19 AM
View All Files
Subscribers
Korvin
Tokens
"Party Time" token, awarded by scp.

Details

Reviewers
scp
epriestley
Commits
rP8af29f2df1a1: Group similar transaction comments in Conpherence
Summary

Adds a CSS class if comments come in from the same user in the past 2 minutes for cleaner UI. Note will have to find some better display UI when comment editing comes.

Test Plan

Test lots of random Conpherence messages with different transactions, different people, and quick commenting.

Diff Detail

Repository
rP Phabricator
Branch
group-transactions (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13928
Build 18037: Run Core Tests
Build 18036: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40039.Sep 29 2016, 7:20 PM
chad retitled this revision from to Group similar transaction comments in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, scp.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 29 2016, 7:20 PM
epriestley accepted this revision.Sep 29 2016, 7:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 7:21 PM
Closed by commit rP8af29f2df1a1: Group similar transaction comments in Conpherence (authored by chad, committed by chad). · Explain WhySep 29 2016, 7:23 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Sep 29 2016, 7:25 PM

@scp you still owe us one. I didn't use your "hax"

scp awarded a token.Sep 30 2016, 3:41 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
conpherence/
20 lines
webroot/
rsrc/
css/
application/
conpherence/
10 lines

Diff 40039

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/ConpherenceTransactionRenderer.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
Phabricator · Built by Phacility