Page MenuHomePhabricator

Link user name in People log view to user page
ClosedPublic

Authored by aklapper on Sep 28 2016, 2:37 PM.
Tags
None
Referenced Files
F13121540: D16620.id40018.diff
Mon, Apr 29, 5:20 PM
F13121539: D16620.id40017.diff
Mon, Apr 29, 5:20 PM
F13121538: D16620.id40011.diff
Mon, Apr 29, 5:20 PM
F13121537: D16620.id.diff
Mon, Apr 29, 5:19 PM
Unknown Object (File)
Sun, Apr 28, 11:42 AM
Unknown Object (File)
Sat, Apr 27, 10:41 AM
Unknown Object (File)
Sat, Apr 27, 7:39 AM
Unknown Object (File)
Thu, Apr 25, 6:15 PM
Subscribers

Details

Summary

Looking at IPs who recently registered more than one account in
Phabricator and trying to figure out whether they are spam bots
or just all on the same university network, I often want to check
recent user activity of these accounts. Hence linking the entries
in the User column to their user page comes in handy.

Test Plan

Tested on local instance and works as expected.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13899
Build 17990: arc lint + arc unit

Event Timeline

aklapper retitled this revision from to Link user name in People log view to user page.
aklapper updated this object.
aklapper edited the test plan for this revision. (Show Details)

Possibly simpler fix inline?

src/applications/people/view/PhabricatorUserLogView.php
75

If you just change this line like this, does that also work?

- $handles[$log->getUserPHID()]->getName(),
+ $handles[$log->getUserPHID()]->renderLink(),
aklapper edited edge metadata.
  • Link user name in people log view to user page
This revision is now accepted and ready to land.Sep 28 2016, 3:47 PM
This revision was automatically updated to reflect the committed changes.

Indeed, that one-liner works (nice API).
Thanks for the extremely fast feedback, as usual!