Page MenuHomePhabricator

Link user name in People log view to user page
ClosedPublic

Authored by aklapper on Sep 28 2016, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 11:07 PM
Unknown Object (File)
Thu, Dec 12, 7:48 AM
Unknown Object (File)
Tue, Dec 3, 7:08 AM
Unknown Object (File)
Mon, Dec 2, 6:13 PM
Unknown Object (File)
Sun, Dec 1, 3:12 AM
Unknown Object (File)
Mon, Nov 25, 3:31 PM
Unknown Object (File)
Nov 19 2024, 6:16 PM
Unknown Object (File)
Nov 18 2024, 11:56 PM
Subscribers

Details

Summary

Looking at IPs who recently registered more than one account in
Phabricator and trying to figure out whether they are spam bots
or just all on the same university network, I often want to check
recent user activity of these accounts. Hence linking the entries
in the User column to their user page comes in handy.

Test Plan

Tested on local instance and works as expected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper retitled this revision from to Link user name in People log view to user page.
aklapper updated this object.
aklapper edited the test plan for this revision. (Show Details)

Possibly simpler fix inline?

src/applications/people/view/PhabricatorUserLogView.php
64

If you just change this line like this, does that also work?

- $handles[$log->getUserPHID()]->getName(),
+ $handles[$log->getUserPHID()]->renderLink(),
aklapper edited edge metadata.
  • Link user name in people log view to user page
This revision is now accepted and ready to land.Sep 28 2016, 3:47 PM
This revision was automatically updated to reflect the committed changes.

Indeed, that one-liner works (nice API).
Thanks for the extremely fast feedback, as usual!