Paths

Table of Contentst

Differential D16591

For now, disable persistent connections and the "max_connections" setup warning
ClosedPublic
Actions

Authored by epriestley on Sep 23 2016, 7:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 9:34 AM

	Unknown Object (File)
	Wed, May 1, 1:43 AM

	Unknown Object (File)
	Tue, Apr 30, 3:52 PM

	Unknown Object (File)
	Sat, Apr 27, 4:41 PM

	Unknown Object (File)
	Fri, Apr 26, 8:12 AM

	Unknown Object (File)
	Thu, Apr 25, 4:06 AM

	Unknown Object (File)
	Thu, Apr 25, 3:13 AM

	Unknown Object (File)
	Sat, Apr 20, 5:32 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T11672: Evaluate persistent connections from HTTP contexts

Commits

rP38b10f05a224: For now, disable persistent connections and the "max_connections" setup warning

Summary

Ref T11672. At low loads, this causes us to use more connections, which is pushing some installs over the default limits.

Rather than trying to walk users through changing max_connections, open_files_limit, fs.file-max, ulimit, etc., just put things back for now. After T11044 we should have headroom to use persistent connections within the default limits on all reasonable systems..

Test Plan

Loaded Phabricator, poked around.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39938.Sep 23 2016, 7:40 PM

epriestley retitled this revision from to For now, disable persistent connections and the "max_connections" setup warning.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11672: Evaluate persistent connections from HTTP contexts.

chad accepted this revision.Sep 23 2016, 7:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 23 2016, 7:41 PM

Closed by commit rP38b10f05a224: For now, disable persistent connections and the "max_connections" setup warning (authored by epriestley, committed by epriestley). · Explain WhySep 23 2016, 7:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorMySQLSetupCheck.php

34 lines

infrastructure/

storage/

lisk/

PhabricatorLiskDAO.php

8 lines

Diff 39939

src/applications/config/check/PhabricatorMySQLSetupCheck.php

Loading...

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...