Page MenuHomePhabricator
Differential D16582

Make "text" custom fields appear in ApplicationSearch again
ClosedPublic
Actions

Authored by epriestley on Sep 21 2016, 9:35 PM.
Tags
None
Referenced Files
F13154649: D16582.diff
Sun, May 5, 4:10 AM
Unknown Object (File)
Wed, May 1, 8:14 PM
Unknown Object (File)
Mon, Apr 29, 5:19 PM
Unknown Object (File)
Mon, Apr 29, 2:37 AM
Unknown Object (File)
Sun, Apr 28, 2:30 PM
Unknown Object (File)
Sun, Apr 28, 9:33 AM
Unknown Object (File)
Fri, Apr 19, 5:19 PM
Unknown Object (File)
Thu, Apr 18, 4:42 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form
Commits
rP8941bbfcea7d: Make "text" custom fields appear in ApplicationSearch again
Summary

Fixes T11675. This capability was erroneously (probably?) removed in D14766.

This search implementation (which uses exact match) probably isn't perfect for all cases of "text" fields, but empirically it seems to be what a significant number of users are after.

Test Plan

Searched for a custom text field value.

Screen Shot 2016-09-21 at 2.31.15 PM.png (421×721 px, 37 KB)

Diff Detail

Repository
rP Phabricator
Branch
searchfield1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13798
Build 17831: Run Core Tests
Build 17830: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39911.Sep 21 2016, 9:35 PM
epriestley retitled this revision from to Make "text" custom fields appear in ApplicationSearch again.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11675: "Text" type custom field in Maniphest not displayed in Maniphest Advanced Search form.
chad accepted this revision.Sep 21 2016, 11:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 21 2016, 11:22 PM
Closed by commit rP8941bbfcea7d: Make "text" custom fields appear in ApplicationSearch again (authored by epriestley, committed by epriestley). · Explain WhySep 21 2016, 11:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
standard/
4 lines

Diff 39911

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php

Loading...
Phabricator · Built by Phacility