Page MenuHomePhabricator
Differential D16562

Remove "needWidgetData" from Conpherence
ClosedPublic
Actions

Authored by chad on Sep 16 2016, 2:36 AM.
Tags
None
Referenced Files
F13105159: D16562.id39866.diff
Sat, Apr 27, 2:21 PM
F13105157: D16562.id39860.diff
Sat, Apr 27, 2:21 PM
Unknown Object (File)
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Wed, Apr 24, 6:31 PM
Unknown Object (File)
Thu, Apr 11, 9:10 AM
Unknown Object (File)
Sun, Apr 7, 10:00 PM
Unknown Object (File)
Mon, Apr 1, 12:31 PM
Unknown Object (File)
Mar 4 2024, 6:16 PM
View All 100 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP5cffe9e5e5fe: Remove "needWidgetData" from Conpherence
Summary

We no longer have widgets, don't need these calls for simplicity.

Test Plan

Add a user to a room, remove a user from a room. Grep for needWidgetData

Diff Detail

Repository
rP Phabricator
Branch
remove-files (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13739
Build 17737: Run Core Tests
Build 17736: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39860.Sep 16 2016, 2:36 AM
chad retitled this revision from to Remove "needWidgetData" from Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 16 2016, 2:36 AM
epriestley requested changes to this revision.Sep 16 2016, 6:39 PM
epriestley edited edge metadata.

Can we also remove ConpherenceThread->getWidgetData() and ConpherenceThread->attachWidgetData()?

This revision now requires changes to proceed.Sep 16 2016, 6:39 PM
chad updated this revision to Diff 39866.Sep 16 2016, 8:47 PM
chad edited edge metadata.
  • updated
epriestley accepted this revision.Sep 16 2016, 8:56 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2016, 8:56 PM
Closed by commit rP5cffe9e5e5fe: Remove "needWidgetData" from Conpherence (authored by chad, committed by chad). · Explain WhySep 16 2016, 8:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
controller/
2 lines
2 lines
query/
108 lines

Diff 39860

View Options

src/applications/conpherence/controller/ConpherenceParticipantController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...
Phabricator · Built by Phacility