Page MenuHomePhabricator

Remove "needWidgetData" from Conpherence
ClosedPublic

Authored by chad on Sep 16 2016, 2:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 6:16 PM
Unknown Object (File)
Feb 20 2024, 3:16 AM
Unknown Object (File)
Feb 8 2024, 4:13 PM
Unknown Object (File)
Jan 22 2024, 9:27 PM
Unknown Object (File)
Dec 31 2023, 11:09 PM
Unknown Object (File)
Dec 26 2023, 6:05 AM
Unknown Object (File)
Dec 25 2023, 1:20 PM
Unknown Object (File)
Dec 19 2023, 7:20 AM
Subscribers

Details

Summary

We no longer have widgets, don't need these calls for simplicity.

Test Plan

Add a user to a room, remove a user from a room. Grep for needWidgetData

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Remove "needWidgetData" from Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Can we also remove ConpherenceThread->getWidgetData() and ConpherenceThread->attachWidgetData()?

This revision now requires changes to proceed.Sep 16 2016, 6:39 PM
chad edited edge metadata.
  • updated
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2016, 8:56 PM
This revision was automatically updated to reflect the committed changes.