Rebuild Conpherence
ClosedPublic
Actions

Authored by chad on Sep 14 2016, 7:27 PM.

Details

Reviewers

epriestley

Commits

rPc1c5fbce2139: Rebuild Conpherence

Summary

Minor rebuild / redesign of Conpherence. Most of this is new UX and tossing out things like widgets, device fallbacks. I expect some of the UI to get more polished after next pass, but most everything here is in place.

Removed "Widgets", now just a single Participants pane
Added "Topic"
New header
Settings, Edit are action icons
Removed a lot of JS
Simplified CSS as much as I could

Test Plan

Desktop, Tablet, Mobile. Adding and removing people. Setting new topics, new rooms.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39834.Sep 14 2016, 7:27 PM

chad retitled this revision from to Rebuild Conpherence.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 14 2016, 7:27 PM

chad edited the test plan for this revision. (Show Details)Sep 14 2016, 7:28 PM

chad edited the test plan for this revision. (Show Details)

Red date dividers feel a little unusual since we usually only use red for errors, although they look fine.
Maybe we already considered it, but fa-user-plus might be a better icon for "invite user"?
I'm seeing some of that scrollbar/click-toggle stuff myself now but I suspect nothing here is causing it.
Remarkup area feels a little weird to me just floating there with no structure.
Maybe at some point no topic when creating a room (like no icon), to simplify the flow?

I dunno if this has anything to do with you or not but I'm getting some extra rooms under "See More", uh, sometimes:

Screen Shot 2016-09-14 at 5.54.50 PM.png (455×282 px, 55 KB)

If you try to set a >255-character topic you get this junk but no one's going to do that and it'll get way easier to fix once we switch to Modular Transactions:

Screen Shot 2016-09-14 at 5.56.17 PM.png (715×1 px, 150 KB)

src/applications/conpherence/controller/ConpherenceController.php
76	Gear and pencil icons maybe swapped? I'd expect pencil to mean "edit object", not "edit [notification] settings".
77	Does it work if you just add `?action=...` to the end of the URL?
src/applications/conpherence/controller/ConpherenceUpdateController.php
284–286	Probably OK to just return `$dialog` nowadays, without explicitly building a separate DialogResponse.
src/applications/conpherence/editor/ConpherenceEditor.php
63	Incorrectly ignores common and useful topic "0".
webroot/rsrc/js/application/conpherence/behavior-toggle-widget.js
16–17	This is the thing covered in T11633?

chad added inline comments.Sep 15 2016, 1:02 AM

webroot/rsrc/js/application/conpherence/behavior-toggle-widget.js
16–17	Yeah, I just didn't know if there is a shortcut to force a redraw... maybe just redraw all messages?

epriestley added inline comments.Sep 15 2016, 1:16 AM

webroot/rsrc/js/application/conpherence/behavior-toggle-widget.js
22	Try this? JX.Stratcom.invoke('resize'); Make sure to put it after the `JX.DOM.alterClass(...)` call.

per comment fixes

Seems to work fine locally thanks!

chad added inline comments.Sep 15 2016, 1:44 AM

src/applications/conpherence/controller/ConpherenceController.php
76	oh hah, yeah I guess I didn't notice that
src/applications/conpherence/view/ConpherenceParticipantView.php
29–36	this is where the extra "person / chat room" comes in when you add someone, from the handle list. probably a one line fix, I'll tinker with tonight