Don't show Conpherence controls if not in a Conpherence
ClosedPublic
Actions

Authored by chad on Sep 13 2016, 5:43 PM.

Details

Reviewers

epriestley

Commits

rP5d8b5c0ee341: Don't show Conpherence controls if not in a Conpherence

Summary

We currently try to build crumbs out even if the user has no membership in any. This removes these useless controls.

Test Plan

Leave all Rooms, see NUX state with no "Edit Room", blank title, or "Collapse Column" controls.

Diff Detail

Repository

rP Phabricator

Branch

conph-default-state (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13707
Build 17687: Run Core Tests
Build 17686: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39827.Sep 13 2016, 5:43 PM

chad retitled this revision from to Don't show Conpherence controls if not in a Conpherence.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 13 2016, 5:43 PM

Fairly bizarre that a $conpherence object even exists in this case, but ehh.

This revision is now accepted and ready to land.Sep 13 2016, 5:45 PM

yeah I'm not sure what's up with that... I can trace it back?

I don't think it's important to fix right away, but should probably get cleaned up when this gets a real iteration.

Closed by commit rP5d8b5c0ee341: Don't show Conpherence controls if not in a Conpherence (authored by chad, committed by chad). · Explain WhySep 13 2016, 5:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceController.php

82 lines

Diff 39827

View Options

src/applications/conpherence/controller/ConpherenceController.php

Don't show Conpherence controls if not in a ConpherenceClosedPublicActions