Page MenuHomePhabricator
Differential D16528

Clean up random junk in Conpherence
ClosedPublic
Actions

Authored by chad on Sep 9 2016, 4:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 24, 1:05 PM
Unknown Object (File)
Mon, Feb 24, 12:38 PM
Unknown Object (File)
Mon, Feb 24, 12:38 PM
Unknown Object (File)
Mon, Feb 24, 12:38 PM
Unknown Object (File)
Mon, Feb 24, 11:14 AM
Unknown Object (File)
Sun, Feb 23, 4:02 AM
Unknown Object (File)
Tue, Feb 18, 11:43 AM
Unknown Object (File)
Sun, Feb 9, 2:22 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10781: Conpherence new links are missing styles
Commits
rP05628de90d8c: Clean up random junk in Conpherence
Summary

Fixes T10781. Re-uses sidenav styles from global space, though a little hacky. Fix crumb border, fix nux experience. Fiddle spacing.

Test Plan

Use Conpherence as new user, make a room, post some messages.

pasted_file (2×2 px, 244 KB)

Diff Detail

Repository
rP Phabricator
Branch
conph-new-room (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13656
Build 17605: Run Core Tests
Build 17604: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39773.Sep 9 2016, 4:36 AM
chad retitled this revision from to Clean up random junk in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10781: Conpherence new links are missing styles.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2016, 4:36 AM
chad edited the test plan for this revision. (Show Details)Sep 9 2016, 4:36 AM
epriestley accepted this revision.Sep 9 2016, 10:54 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 10:54 AM
Closed by commit rP05628de90d8c: Clean up random junk in Conpherence (authored by chad, committed by chad). · Explain WhySep 9 2016, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
applications/
conpherence/
controller/
7 lines
view/
7 lines
6 lines
8 lines
webroot/
rsrc/
css/
application/
conpherence/
15 lines
10 lines

Diff 39773

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceLayoutView.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceMenuItemView.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/menu.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...
Phabricator · Built by Phacility