Page MenuHomePhabricator

Respect "End Date" for recurring Calendar events in detail UI
ClosedPublic

Authored by epriestley on Sep 8 2016, 4:15 PM.
Tags
None
Referenced Files
F14731017: D16517.id39751.diff
Sat, Jan 18, 7:53 AM
Unknown Object (File)
Fri, Dec 20, 11:46 PM
Unknown Object (File)
Dec 12 2024, 12:56 AM
Unknown Object (File)
Dec 9 2024, 3:35 AM
Unknown Object (File)
Dec 8 2024, 3:33 AM
Unknown Object (File)
Nov 29 2024, 1:04 AM
Unknown Object (File)
Nov 28 2024, 9:39 AM
Unknown Object (File)
Nov 28 2024, 9:39 AM
Subscribers
None
Tokens
"Love" token, awarded by 20after4.

Details

Summary

Fixes T11396. Currently, you can keep clicking "Next >" forever to generate infinite instances of an event, even if it has a set end date.

Likewise, you can visit /E123/999999 or whatever to stub out the 999999th instance of an event.

Instead:

  • Before creating a new stub, make sure it happens before any end date.
  • 404 stubs if we can't create them.
  • Disable the "Next >" button if it isn't valid.
Test Plan
  • Visited /E123/9999 for an event with a recurrence end date, got 404.
  • Clicked "Next >" on an event with an end date, got new events until I hit the end date.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Respect "End Date" for recurring Calendar events in detail UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2016, 4:47 PM
This revision was automatically updated to reflect the committed changes.