Page MenuHomePhabricator

Properly set project icon in timeline
ClosedPublic

Authored by chad on Sep 7 2016, 5:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 5:20 AM
Unknown Object (File)
Tue, Mar 5, 7:23 AM
Unknown Object (File)
Feb 20 2024, 3:15 AM
Unknown Object (File)
Feb 15 2024, 4:47 PM
Unknown Object (File)
Feb 13 2024, 6:28 PM
Unknown Object (File)
Feb 11 2024, 4:11 PM
Unknown Object (File)
Feb 8 2024, 1:58 PM
Unknown Object (File)
Jan 30 2024, 9:26 AM
Subscribers

Details

Summary

This fixes a bug where the icon won't display since it doesn't include fa-.

Test Plan

Change icon on a project, revisit timeline and see icon.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Properly set project icon in timeline.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 5:36 PM

Actually, I think this is maybe still wrong? I think $new is just a key which happens to be the right value most of the time.

Actual code is this, I believe:

$set = new PhabricatorProjectIconSet();
$font_icon = $set->getIconIcon($new);
This revision was automatically updated to reflect the committed changes.

(If you set it to the "lock" icon I think this will try to render fa-policy, which is incorrect/invalid/does not exist.)

ah, I only tested group. I guess I got lucky.