Page MenuHomePhabricator
Differential D16510

Add a {key ..} Remarkup rule for discussing keystrokes
ClosedPublic
Actions

Authored by epriestley on Sep 7 2016, 3:53 PM.
Tags
None
Referenced Files
F13305521: D16510.diff
Sat, Jun 8, 11:27 PM
F13304921: D16510.id39730.diff
Sat, Jun 8, 2:38 PM
F13304612: D16510.id39736.diff
Sat, Jun 8, 11:03 AM
F13301938: D16510.diff
Sat, Jun 8, 3:47 AM
F13290736: D16510.id.diff
Tue, Jun 4, 7:57 PM
F13267768: D16510.diff
Wed, May 29, 4:13 AM
F13266765: D16510.id.diff
Tue, May 28, 7:13 PM
F13253218: D16510.diff
Sat, May 25, 2:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rP5f43abd7efb8: Add a {key ..} Remarkup rule for discussing keystrokes
Summary

Ruleset for styles in D16506.

Test Plan

Screen Shot 2016-09-07 at 8.50.30 AM.png (664×1 px, 75 KB)

Diff Detail

Repository
rP Phabricator
Branch
keymark
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13610
Build 17537: Run Core Tests
Build 17536: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39730.Sep 7 2016, 3:53 PM
epriestley retitled this revision from to Add a {key ..} Remarkup rule for discussing keystrokes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptSep 7 2016, 3:53 PM
chad accepted this revision.Sep 7 2016, 3:54 PM
chad edited edge metadata.
chad added inline comments.
src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php
12

holy guacamole.

This revision is now accepted and ready to land.Sep 7 2016, 3:54 PM
epriestley updated this revision to Diff 39731.Sep 7 2016, 3:55 PM
epriestley edited edge metadata.
  • It seems that "hadoken" is a more accepted spelling.
epriestley updated this revision to Diff 39732.Sep 7 2016, 4:07 PM
  • Fix some escaping stuff so {key \\} works.
  • Stop trimming commas so {key ,} works.
  • Add a symbol for "tab".
Closed by commit rP5f43abd7efb8: Add a {key ..} Remarkup rule for discussing keystrokes (authored by epriestley, committed by epriestley). · Explain WhySep 7 2016, 4:09 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Sep 7 2016, 4:15 PM

( This is live. )

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
2 lines
docs/
user/
userguide/
26 lines
infrastructure/
markup/
1 line
rule/
215 lines
webroot/
rsrc/
css/
core/
5 lines

Diff 39731

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility