Page MenuHomePhabricator
Differential D16502

Continue on bad database configuration from select scripts
ClosedPublic
Actions

Authored by epriestley on Sep 6 2016, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 5:18 PM
Unknown Object (File)
Mon, Apr 29, 5:18 PM
Unknown Object (File)
Mon, Apr 29, 5:18 PM
Unknown Object (File)
Thu, Apr 25, 11:43 PM
Unknown Object (File)
Thu, Apr 25, 6:13 PM
Unknown Object (File)
Fri, Apr 19, 5:17 PM
Unknown Object (File)
Thu, Apr 18, 4:41 PM
Unknown Object (File)
Fri, Apr 12, 8:56 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages
Commits
rP32a580c720e3: (stable) Continue on bad database configuration from select scripts
rP0e8ceeb69088: Continue on bad database configuration from select scripts
Summary

Ref T11589. Provide a way for scripts to say "just continue if database config fails", and use it in bin/config and bin/storage.

Test Plan
  • Broke database config.
  • Ran bin/config, worked fine.
  • Ran bin/storage, got helpful "set up the database" message.
  • Ran bin/repository, got fatal.
  • Ran normal site with valid/invalid config, got proper feedback.

Diff Detail

Repository
rP Phabricator
Branch
init4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13591
Build 17508: Run Core Tests
Build 17507: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39712.Sep 6 2016, 8:25 PM
epriestley retitled this revision from to Continue on bad database configuration from select scripts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.
chad accepted this revision.Sep 6 2016, 8:32 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2016, 8:32 PM
Closed by commit rP0e8ceeb69088: Continue on bad database configuration from select scripts (authored by epriestley, committed by epriestley). · Explain WhySep 6 2016, 9:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
23 lines
init/
10 lines
12 lines
init/
lib.php
__init_script__.php
11 lines
setup/
2 lines
sql/
2 lines
src/
infrastructure/
env/
20 lines

Diff 39712

View Options

scripts/__init_script__.php

Loading...
View Options

scripts/init/init-script.php

Loading...
View Options

scripts/init/init-setup.php

Loading...
View Options

scripts/init/lib.php

Loading...
View Options

scripts/setup/manage_config.php

Loading...
View Options

scripts/sql/manage_storage.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
Phabricator · Built by Phacility