Page MenuHomePhabricator

Split setup checks into "preflight" and "normal" checks
ClosedPublic

Authored by epriestley on Sep 6 2016, 6:11 PM.
Tags
None
Referenced Files
F15507901: D16499.id39709.diff
Tue, Apr 15, 11:59 PM
F15460829: D16499.id39708.diff
Tue, Apr 1, 2:44 AM
F15446610: D16499.id39709.diff
Thu, Mar 27, 7:38 PM
F15446609: D16499.id39708.diff
Thu, Mar 27, 7:38 PM
F15446608: D16499.id.diff
Thu, Mar 27, 7:38 PM
F15444806: D16499.id.diff
Thu, Mar 27, 11:24 AM
F15442620: D16499.diff
Wed, Mar 26, 11:50 PM
F15435176: D16499.diff
Mar 25 2025, 7:16 AM
Subscribers
None

Details

Summary

Ref T11589. Currently, initialization order is a bit tangled: we load configuration from the database, then later test if we can connect to the database.

Instead, I'm going to do: preflight checks ("PHP Version OK?", "Extensions installed?"), then configuration, then normal setup checks.

To prepare for this, flag core checks as "preflight" and add a setup panel to visually confirm that I didn't miss anything.

Test Plan

Screen Shot 2016-09-06 at 11.02.44 AM.png (1×1 px, 299 KB)

Diff Detail

Repository
rP Phabricator
Branch
init1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13587
Build 17501: Run Core Tests
Build 17500: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Split setup checks into "preflight" and "normal" checks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2016, 6:17 PM
This revision was automatically updated to reflect the committed changes.