Page MenuHomePhabricator
Differential D16489

Distinguish between unreachable cluster database hosts and missing MySQL databases
ClosedPublic
Actions

Authored by epriestley on Sep 2 2016, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 8:52 PM
Unknown Object (File)
Wed, Apr 3, 7:23 AM
Unknown Object (File)
Mar 23 2024, 7:05 PM
Unknown Object (File)
Mar 22 2024, 11:54 PM
Unknown Object (File)
Mar 13 2024, 6:56 PM
Unknown Object (File)
Feb 7 2024, 10:40 PM
Unknown Object (File)
Jan 28 2024, 11:00 AM
Unknown Object (File)
Jan 12 2024, 4:04 PM
View All 99 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11577: Initializing databases for the first time while already in cluster mode fails
Commits
rPd0013d08983a: Distinguish between unreachable cluster database hosts and missing MySQL…
Summary

Fixes T11577. When we connect to a host and try to select a database which does not exist, we currently treat it as though the host wasn't reachable.

This isn't correct, and prevents storage from being initialized while already in cluster mode, since the "config" database won't exist yet the first time we connect.

Instead, distinguish between AphrontSchemaQueryException (thrown on connection if the requested database is not present) and other errors.

Test Plan
  • Put Phabricator into cluster database mode (cluster.databases = ...).
  • Swapped storage.default-namespace to force initialization of a new install.
  • Ran bin/storage upgrade.
    • Before patch: Immediate fatal about unreachablility.
    • After patch: Database initialized.
  • Also ran initialization steps in tranditional single-host mode (cluster.databases empty, mysql.host configured).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39672.Sep 2 2016, 3:08 PM
epriestley retitled this revision from to Distinguish between unreachable cluster database hosts and missing MySQL databases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11577: Initializing databases for the first time while already in cluster mode fails.
chad accepted this revision.Sep 2 2016, 3:11 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 2 2016, 3:11 PM
epriestley edited the test plan for this revision. (Show Details)Sep 2 2016, 3:12 PM
epriestley edited edge metadata.
Closed by commit rPd0013d08983a: Distinguish between unreachable cluster database hosts and missing MySQL… (authored by epriestley, committed by epriestley). · Explain WhySep 2 2016, 3:23 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11579: DB column missing default value or should be nullable....Sep 2 2016, 8:27 PM
epriestley mentioned this in T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.Sep 5 2016, 3:02 PM
epriestley mentioned this in D16501: Raise setup warnings immediately when failing to load configuration from the database.Sep 6 2016, 7:59 PM
epriestley mentioned this in rP00bb0c907147: Raise setup warnings immediately when failing to load configuration from the….Sep 6 2016, 9:20 PM
epriestley mentioned this in rPa1338bd2d889: (stable) Raise setup warnings immediately when failing to load configuration….Sep 8 2016, 2:25 PM

Revision Contents
Changeset List

PathSize
src/
infrastructure/
cluster/
6 lines
env/
2 lines

Diff 39674

View Options

src/infrastructure/cluster/PhabricatorDatabaseRef.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
Phabricator · Built by Phacility