Page MenuHomePhabricator
Differential D16478

Convert Guides to Modules
ClosedPublic
Actions

Authored by chad on Aug 31 2016, 7:15 PM.
Tags
None
Referenced Files
F13157277: D16478.diff
Sun, May 5, 10:29 AM
Unknown Object (File)
Fri, May 3, 2:39 AM
Unknown Object (File)
Mon, Apr 29, 2:12 PM
Unknown Object (File)
Wed, Apr 24, 10:16 PM
Unknown Object (File)
Tue, Apr 16, 2:49 PM
Unknown Object (File)
Mar 29 2024, 11:54 PM
Unknown Object (File)
Mar 29 2024, 11:13 PM
Unknown Object (File)
Mar 29 2024, 9:01 PM
View All Files
Subscribers
Korvin
Tokens
"Manufacturing Defect?" token, awarded by epriestley.

Details

Reviewers
epriestley
Commits
rPb5c9c64b0f2e: Convert Guides to Modules
Summary

Splitting these up to re-use in Config as a stop gap.

Test Plan

Visit welcome, install, and quick start on guides app

Diff Detail

Repository
rP Phabricator
Branch
remove-guides (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13522
Build 17400: Run Core Tests
Build 17399: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39647.Aug 31 2016, 7:15 PM
chad retitled this revision from to Convert Guides to Modules.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 31 2016, 7:15 PM
epriestley accepted this revision.Aug 31 2016, 7:20 PM
epriestley edited edge metadata.

Nicely done!

This revision is now accepted and ready to land.Aug 31 2016, 7:20 PM
epriestley awarded a token.Aug 31 2016, 7:20 PM
Closed by commit rPb5c9c64b0f2e: Convert Guides to Modules (authored by chad, committed by chad). · Explain WhyAug 31 2016, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39647

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/guides/application/PhabricatorGuideApplication.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideController.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideInstallController.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideModuleController.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideQuickStartController.php

Loading...
View Options

src/applications/guides/controller/PhabricatorGuideWelcomeController.php

Loading...
View Options

src/applications/guides/module/PhabricatorGuideInstallModule.php

Loading...
View Options

src/applications/guides/module/PhabricatorGuideModule.php

Loading...
View Options

src/applications/guides/module/PhabricatorGuideQuickStartModule.php

Loading...
View Options

src/applications/guides/module/PhabricatorGuideWelcomeModule.php

Loading...
Phabricator · Built by Phacility