Page MenuHomePhabricator

Provide a new "hint" table for weird commits (rewritten, unreadable)
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:06 PM.
Tags
None
Referenced Files
F15444533: D16434.id39525.diff
Thu, Mar 27, 9:56 AM
F15444467: D16434.diff
Thu, Mar 27, 9:44 AM
F15442561: D16434.id39540.diff
Wed, Mar 26, 11:48 PM
F15442558: D16434.id39525.diff
Wed, Mar 26, 11:48 PM
F15442553: D16434.id.diff
Wed, Mar 26, 11:48 PM
F15434162: D16434.id39525.diff
Tue, Mar 25, 2:20 AM
F15433668: D16434.diff
Tue, Mar 25, 12:15 AM
F15430003: D16434.id.diff
Mon, Mar 24, 5:12 AM
Subscribers
None

Details

Summary

Ref T11522. This provides storage for tracking rewritten commits (new feature) and unreadable commits (existing feature, but really hacky).

This doesn't do anything yet, just adds a table and a CLI tool for updating it. I'll document the tool once it works. You just pipe in some JSON, but I need to document the format.

Test Plan
  • Piped JSON for "none", "rewritten" and "unreadable" hints into bin/repository hint.
  • Examined the database to see that the table was written properly.
  • Tried to pipe bad JSON in, invalid hint types, etc. Got reasonable human-readable error messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a new "hint" table for weird commits (rewritten, unreadable).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.