Page MenuHomePhabricator

Provide a new "hint" table for weird commits (rewritten, unreadable)
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:06 PM.
Tags
None
Referenced Files
F18753643: D16434.id.diff
Sat, Oct 4, 7:46 PM
F18657768: D16434.id39540.diff
Sep 23 2025, 3:19 AM
F18622809: D16434.id39525.diff
Sep 15 2025, 1:03 PM
F18092582: D16434.id39525.diff
Aug 7 2025, 11:37 AM
F18003803: D16434.id39540.diff
Aug 2 2025, 11:57 AM
F17956111: D16434.id.diff
Aug 1 2025, 5:20 AM
F17944401: D16434.diff
Jul 31 2025, 10:00 AM
F17755310: D16434.id39525.diff
Jul 22 2025, 12:10 PM
Subscribers
None

Details

Summary

Ref T11522. This provides storage for tracking rewritten commits (new feature) and unreadable commits (existing feature, but really hacky).

This doesn't do anything yet, just adds a table and a CLI tool for updating it. I'll document the tool once it works. You just pipe in some JSON, but I need to document the format.

Test Plan
  • Piped JSON for "none", "rewritten" and "unreadable" hints into bin/repository hint.
  • Examined the database to see that the table was written properly.
  • Tried to pipe bad JSON in, invalid hint types, etc. Got reasonable human-readable error messages.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide a new "hint" table for weird commits (rewritten, unreadable).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:53 PM
This revision was automatically updated to reflect the committed changes.