Page MenuHomePhabricator
Differential D16424

Add setBackground to PHUIIconView
ClosedPublic
Actions

Authored by chad on Aug 19 2016, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 10:43 PM
Unknown Object (File)
Tue, Apr 16, 2:49 PM
Unknown Object (File)
Thu, Apr 11, 6:16 PM
Unknown Object (File)
Tue, Apr 9, 12:15 AM
Unknown Object (File)
Mon, Apr 8, 11:58 PM
Unknown Object (File)
Mon, Apr 8, 11:57 PM
Unknown Object (File)
Tue, Apr 2, 9:46 AM
Unknown Object (File)
Tue, Apr 2, 9:33 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11132: New Phabricator NUX
Commits
rPf379858874a3: Add setBackground to PHUIIconView
Summary

Ref T11132. Adds a background color option to PHUIIconView, for use whereever, and NUX. Also normalize icon placement for mixed image/icon result list.

Test Plan

Test in UIExamples, and Global Settings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 39495.Aug 19 2016, 7:49 PM
chad retitled this revision from to Add setBackground to PHUIIconView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11132: New Phabricator NUX.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 19 2016, 7:49 PM
chad added a comment.Aug 19 2016, 7:49 PM

pasted_file (272×419 px, 25 KB)

epriestley accepted this revision.Aug 19 2016, 8:17 PM
epriestley edited edge metadata.

its bluetiful :3

This revision is now accepted and ready to land.Aug 19 2016, 8:17 PM
Closed by commit rPf379858874a3: Add setBackground to PHUIIconView (authored by chad, committed by chad). · Explain WhyAug 19 2016, 8:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
applications/
settings/
query/
7 lines
uiexample/
examples/
22 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
font/
39 lines
phui/
17 lines
34 lines

Diff 39496

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/query/PhabricatorUserPreferencesSearchEngine.php

Loading...
View Options

src/applications/uiexample/examples/PHUIIconExample.php

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
View Options

webroot/rsrc/css/font/phui-font-icon-base.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility