Page MenuHomePhabricator
Differential D16398

Fix bad array index test in Differential package code
ClosedPublic
Actions

Authored by epriestley on Aug 14 2016, 8:08 PM.
Tags
None
Referenced Files
F19152113: D16398.diff
Thu, Dec 11, 12:44 AM
F19095719: D16398.diff
Thu, Dec 4, 5:54 AM
F19070939: D16398.diff
Sun, Nov 30, 6:12 PM
F18863492: D16398.id.diff
Nov 2 2025, 11:43 PM
F18855620: D16398.diff
Nov 1 2025, 5:56 AM
F18168768: D16398.id39435.diff
Aug 15 2025, 4:21 PM
F18113531: D16398.id39434.diff
Aug 13 2025, 2:31 AM
F18113361: D16398.id.diff
Aug 13 2025, 1:40 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rP15021a0bcc91: Fix bad array index test in Differential package code
Summary

This needs an isset() for cases when authority and packages don't completely overlap.

Test Plan
  • With a package set to trigger autoreview, created a revision.
  • Observed error log, saw no more error.
  • Saw package trigger autoreview properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39434.Aug 14 2016, 8:08 PM
epriestley retitled this revision from to Fix bad array index test in Differential package code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Aug 14 2016, 8:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2016, 8:10 PM
Closed by commit rP15021a0bcc91: Fix bad array index test in Differential package code (authored by epriestley, committed by epriestley). · Explain WhyAug 14 2016, 8:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
2 lines

Diff 39435

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility