Increase the storage size for commit summaries
ClosedPublic
Actions

Authored by epriestley on Aug 10 2016, 4:52 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T11453: Increase storage size of "summary" column on DiffusionRepositoryCommit

Commits

rPe8083ad63a32: Increase the storage size for commit summaries

Summary

Fixes T11453. Currently, commit message summaries are limited to 80 bytes. This may only be 20-40 characters for CJK languages or langauges with Cyrillic script.

Increase storage size to 255, then truncate to the shorter of 255 bytes or 80 glyphs. This preserves the same behavior for latin languages, but is less tight for Russian, etc.

Some minor additional changes:

Provide a way to ask "how much data fits in this column?" so we don't have to duplicate column lengths across summary checks or UI errors like "title too long".
Remove the text80 datatype, since no other columns use it and we have no use cases (or likely use cases) for it.

Test Plan

Made a commit with a Cyrillic title, saw reasonable summarization in UI:

Added and ran unit tests.
Grepped for removed SUMMARY_MAX_LENGTH constant.
Grepped for removed text80 data type.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39407.Aug 10 2016, 4:52 PM

epriestley retitled this revision from to Increase the storage size for commit summaries.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11453: Increase storage size of "summary" column on DiffusionRepositoryCommit.

epriestley mentioned this in T11453: Increase storage size of "summary" column on DiffusionRepositoryCommit.Aug 10 2016, 4:54 PM

nice!
Any guesses how expensive the migration would be?

This revision is now accepted and ready to land.Aug 10 2016, 5:48 PM

About tree fitty

I'll have an actual number for this install once this deploys, but we've seen like >10x variance for similar data sizes in the past so I've pretty much given up trying to guess. These are usually pretty cheap, though, and the table isn't that big (usually only millions of rows even for large installs). I'd guess no more than a few minutes in the worst case?