Page MenuHomePhabricator
Differential D16377

Make new logo and wordmark more reasonably configurable by human users
ClosedPublic
Actions

Authored by epriestley on Aug 7 2016, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 4:12 PM
Unknown Object (File)
Thu, Dec 12, 4:38 AM
Unknown Object (File)
Tue, Dec 10, 11:10 AM
Unknown Object (File)
Sun, Dec 8, 9:50 AM
Unknown Object (File)
Thu, Dec 5, 4:37 PM
Unknown Object (File)
Wed, Dec 4, 1:39 PM
Unknown Object (File)
Sat, Nov 30, 6:05 AM
Unknown Object (File)
Tue, Nov 26, 5:04 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11437: Provide a usable UI for configuring header logos
Commits
rP3a002b6b83d6: Make new logo and wordmark more reasonably configurable by human users
Summary

Fixes T11437. Provides a normal form for configuring this, instead of weird "look up the PHID and adjust things in the database" stuff.

Test Plan

Screen Shot 2016-08-07 at 11.48.55 AM.png (182×270 px, 18 KB)

Screen Shot 2016-08-07 at 11.48.58 AM.png (549×1 px, 79 KB)

Diff Detail

Repository
rP Phabricator
Branch
header1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/custom/PhabricatorCustomLogoConfigType.php:92XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 13265
Build 17004: Run Core Tests
Build 17003: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39388.Aug 7 2016, 6:52 PM
epriestley retitled this revision from to Make new logo and wordmark more reasonably configurable by human users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11437: Provide a usable UI for configuring header logos.
chad accepted this revision.Aug 7 2016, 6:55 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 7 2016, 6:55 PM
Closed by commit rP3a002b6b83d6: Make new logo and wordmark more reasonably configurable by human users (authored by epriestley, committed by epriestley). · Explain WhyAug 7 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39388

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/custom/PhabricatorConfigOptionType.php

Loading...
View Options

src/applications/config/custom/PhabricatorCustomHeaderConfigType.php

Loading...
View Options

src/applications/config/custom/PhabricatorCustomLogoConfigType.php

Loading...
View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
Phabricator · Built by Phacility