Page MenuHomePhabricator
Differential D16370

Convert bin/storage workflow to presume utf8mb4 as the default encoding
ClosedPublic
Actions

Authored by eadler on Aug 5 2016, 9:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 2:40 PM
Unknown Object (File)
Wed, Dec 11, 6:07 AM
Unknown Object (File)
Mon, Dec 9, 2:35 PM
Unknown Object (File)
Sun, Dec 8, 12:10 AM
Unknown Object (File)
Sat, Dec 7, 11:07 AM
Unknown Object (File)
Sat, Dec 7, 7:54 AM
Unknown Object (File)
Fri, Dec 6, 1:16 PM
Unknown Object (File)
Thu, Dec 5, 1:27 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPf03214659104: Convert bin/storage workflow to presume utf8mb4 as the default encoding
Summary

see comments on rP68904d941c54

Test Plan

run ,/bin/storage upgrade

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

eadler updated this revision to Diff 39371.Aug 5 2016, 9:21 AM
eadler retitled this revision from to Convert bin/storage workflow to presume utf8mb4 as the default encoding.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2016, 9:21 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Aug 8 2016, 4:19 PM
epriestley edited edge metadata.

This might possibly get us into trouble with clients that don't have utf8mb4, but modern clients should and I think this command probably doesn't see much use on small/old/weird installs.

I don't see an easy way to test the client to see if it supports a given character set, either. Let's just try this and see if it causes issues or not.

This revision is now accepted and ready to land.Aug 8 2016, 4:20 PM
Closed by commit rPf03214659104: Convert bin/storage workflow to presume utf8mb4 as the default encoding (authored by eadler, committed by eadler). · Explain WhyAug 10 2016, 12:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
management/
workflow/
2 lines

Diff 39402

View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementShellWorkflow.php

Loading...
Phabricator · Built by Phacility