Page MenuHomePhabricator
Differential D16367

Use consistent tag order in Maniphest list views and workboard cards
ClosedPublic
Actions

Authored by epriestley on Aug 3 2016, 11:16 PM.
Tags
None
Referenced Files
F13060018: D16367.diff
Fri, Apr 19, 5:11 PM
Unknown Object (File)
Mon, Apr 8, 10:00 PM
Unknown Object (File)
Tue, Apr 2, 11:48 AM
Unknown Object (File)
Mon, Apr 1, 2:05 AM
Unknown Object (File)
Fri, Mar 29, 11:14 AM
Unknown Object (File)
Thu, Mar 28, 12:24 PM
Unknown Object (File)
Mar 15 2024, 11:09 PM
Unknown Object (File)
Mar 13 2024, 7:35 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11420: Stable sort project tags in query results
Commits
rP8f4a63d7083d: Use consistent tag order in Maniphest list views and workboard cards
Summary

Fixes T11420. These are selected in newest-to-oldest order from the database, but we should show them in oldest-to-newest order in the UI.

Test Plan

Tagged a couple tasks with "A, B, C" projects, saw correct order in UI:

Screen Shot 2016-08-03 at 4.14.03 PM.png (148×332 px, 16 KB)

Screen Shot 2016-08-03 at 4.15.17 PM.png (200×344 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
tagorder1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13244
Build 16973: Run Core Tests
Build 16972: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39366.Aug 3 2016, 11:16 PM
epriestley retitled this revision from to Use consistent tag order in Maniphest list views and workboard cards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11420: Stable sort project tags in query results.
epriestley mentioned this in T11420: Stable sort project tags in query results.Aug 3 2016, 11:20 PM
chad accepted this revision.Aug 3 2016, 11:38 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2016, 11:38 PM
Closed by commit rP8f4a63d7083d: Use consistent tag order in Maniphest list views and workboard cards (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2016, 11:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
view/
2 lines
project/
view/
1 line

Diff 39366

View Options

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...
View Options

src/applications/project/view/ProjectBoardTaskCard.php

Loading...
Phabricator · Built by Phacility