Differential D16367

Use consistent tag order in Maniphest list views and workboard cards
ClosedPublic
Actions

Authored by epriestley on Aug 3 2016, 11:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T11420: Stable sort project tags in query results

Commits

rP8f4a63d7083d: Use consistent tag order in Maniphest list views and workboard cards

Summary

Fixes T11420. These are selected in newest-to-oldest order from the database, but we should show them in oldest-to-newest order in the UI.

Test Plan

Tagged a couple tasks with "A, B, C" projects, saw correct order in UI:

Screen Shot 2016-08-03 at 4.14.03 PM.png (148×332 px, 16 KB)

Screen Shot 2016-08-03 at 4.15.17 PM.png (200×344 px, 15 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39366.Aug 3 2016, 11:16 PM

epriestley retitled this revision from to Use consistent tag order in Maniphest list views and workboard cards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11420: Stable sort project tags in query results.

epriestley mentioned this in T11420: Stable sort project tags in query results.Aug 3 2016, 11:20 PM

chad accepted this revision.Aug 3 2016, 11:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 3 2016, 11:38 PM

Closed by commit rP8f4a63d7083d: Use consistent tag order in Maniphest list views and workboard cards (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2016, 11:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

view/

ManiphestTaskListView.php

2 lines

project/

view/

ProjectBoardTaskCard.php

1 line

Diff 39368

View Options

src/applications/maniphest/view/ManiphestTaskListView.php