Page MenuHomePhabricator

When a task graph has too much stuff, only show adjacent nodes (direct parents/children)
ClosedPublic

Authored by epriestley on Jul 28 2016, 8:57 PM.
Tags
None
Referenced Files
F13157562: D16344.id.diff
Sun, May 5, 12:32 PM
F13157561: D16344.id39303.diff
Sun, May 5, 12:32 PM
F13157560: D16344.id39305.diff
Sun, May 5, 12:32 PM
Unknown Object (File)
Mon, Apr 29, 2:11 PM
Unknown Object (File)
Sun, Apr 28, 1:46 AM
Unknown Object (File)
Sat, Apr 27, 6:23 PM
Unknown Object (File)
Wed, Apr 24, 9:25 PM
Unknown Object (File)
Fri, Apr 19, 5:08 PM
Subscribers

Details

Summary

Ref T4788. This gives us a new level of graceful degradation, so now we show:

  • Zero through 100 connected tasks: whole graph.
  • More than 100 connnected tasks, but fewer than 100 direct parents/subtasks: just parents and subtasks, with "..." to hint that the graph is cut off.
  • More than 100 parents and children: just the "sorry, too much stuff" error message.
Test Plan

Screen Shot 2016-07-28 at 1.53.41 PM.png (903×1 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Branch
task5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13179
Build 16873: Run Core Tests
Build 16872: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When a task graph has too much stuff, only show adjacent nodes (direct parents/children).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 28 2016, 10:17 PM
This revision was automatically updated to reflect the committed changes.