Page MenuHomePhabricator

Give the Calendar month view a nice hover effect
ClosedPublic

Authored by epriestley on Jul 27 2016, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 11:11 AM
Unknown Object (File)
Wed, Dec 4, 11:11 AM
Unknown Object (File)
Wed, Dec 4, 11:11 AM
Unknown Object (File)
Wed, Dec 4, 10:56 AM
Unknown Object (File)
Wed, Dec 4, 10:37 AM
Unknown Object (File)
Mon, Nov 25, 1:24 PM
Unknown Object (File)
Thu, Nov 21, 8:58 PM
Unknown Object (File)
Nov 17 2024, 5:28 PM
Subscribers
None

Details

Summary

Ref T11326. Currently, we link Calendar days using hidden DOM nodes.

This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers.

Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise.

Test Plan

Screen Shot 2016-07-27 at 6.44.23 AM.png (225×617 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give the Calendar month view a nice hover effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.