Page MenuHomePhabricator

Give the Calendar month view a nice hover effect
ClosedPublic

Authored by epriestley on Jul 27 2016, 1:50 PM.
Tags
None
Referenced Files
F19316772: D16334.id39272.diff
Thu, Dec 25, 5:02 AM
F19069277: D16334.id.diff
Nov 30 2025, 1:31 PM
F19063191: D16334.diff
Nov 29 2025, 6:07 PM
F18867899: D16334.diff
Nov 4 2025, 3:27 AM
F18850042: D16334.id.diff
Oct 30 2025, 2:02 PM
F18846265: D16334.diff
Oct 29 2025, 6:10 PM
F18763806: D16334.diff
Oct 7 2025, 2:19 AM
F18699049: D16334.id.diff
Sep 27 2025, 12:17 PM
Subscribers
None

Details

Summary

Ref T11326. Currently, we link Calendar days using hidden DOM nodes.

This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers.

Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise.

Test Plan

Screen Shot 2016-07-27 at 6.44.23 AM.png (225×617 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give the Calendar month view a nice hover effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.