Page MenuHomePhabricator

Give the Calendar month view a nice hover effect
ClosedPublic

Authored by epriestley on Jul 27 2016, 1:50 PM.
Tags
None
Referenced Files
F15574493: D16334.diff
Tue, May 6, 1:49 AM
F15558085: D16334.id39279.diff
Tue, Apr 29, 12:56 AM
F15546112: D16334.id.diff
Sat, Apr 26, 1:52 PM
F15532980: D16334.diff
Wed, Apr 23, 5:49 PM
F15455923: D16334.diff
Mar 30 2025, 5:44 AM
F15440947: D16334.id.diff
Mar 26 2025, 3:37 PM
F15438203: D16334.id39279.diff
Mar 25 2025, 11:45 PM
F15434680: D16334.id39272.diff
Mar 25 2025, 4:54 AM
Subscribers
None

Details

Summary

Ref T11326. Currently, we link Calendar days using hidden DOM nodes.

This is nice because it's simple, and right-clicking a day works properly. However, it's a bit ugly/unintuitive, messy, and unclear. It's especially messy because days are really two different rows, one for events and one for day/week numbers.

Instead, use JS to highlight day cells. You can still right-click by clicking the actual day number, which seems like a reasonable compromise.

Test Plan

Screen Shot 2016-07-27 at 6.44.23 AM.png (225×617 px, 30 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give the Calendar month view a nice hover effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 27 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.