Page MenuHomePhabricator

Hide time controls when editing all-day Calendar events
ClosedPublic

Authored by epriestley on Jul 26 2016, 6:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:41 AM
Unknown Object (File)
Sat, Apr 6, 1:39 AM
Unknown Object (File)
Wed, Apr 3, 1:16 AM
Unknown Object (File)
Tue, Mar 26, 9:31 PM
Unknown Object (File)
Fri, Mar 22, 8:49 PM
Unknown Object (File)
Feb 6 2024, 9:04 AM
Unknown Object (File)
Jan 23 2024, 9:33 AM
Unknown Object (File)
Jan 9 2024, 4:26 PM
Subscribers
None

Details

Summary

Ref T11326. When an event is all-day, hide the time controls for the start/end dates. These aren't used and aren't helpful/useful.

This got a little more complicated than it used to be because EditEngine forms may have only some of these controls present.

Test Plan

Edited an all-day event; edited a normal event; swapped an event between normal and all-day.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Hide time controls when editing all-day Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.