Page MenuHomePhabricator

Hide time controls when editing all-day Calendar events
ClosedPublic

Authored by epriestley on Jul 26 2016, 6:23 PM.
Tags
None
Referenced Files
F19104112: D16327.diff
Fri, Dec 5, 12:49 PM
F19040116: D16327.diff
Wed, Nov 26, 11:02 AM
F18878510: D16327.id.diff
Nov 6 2025, 5:21 PM
F18178276: D16327.id39256.diff
Aug 16 2025, 1:15 AM
Unknown Object (File)
Jun 17 2025, 10:51 AM
Unknown Object (File)
Jun 17 2025, 7:22 AM
Unknown Object (File)
Jun 2 2025, 2:35 AM
Unknown Object (File)
May 30 2025, 12:57 PM
Subscribers
None

Details

Summary

Ref T11326. When an event is all-day, hide the time controls for the start/end dates. These aren't used and aren't helpful/useful.

This got a little more complicated than it used to be because EditEngine forms may have only some of these controls present.

Test Plan

Edited an all-day event; edited a normal event; swapped an event between normal and all-day.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Hide time controls when editing all-day Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.