Page MenuHomePhabricator

Hide time controls when editing all-day Calendar events
ClosedPublic

Authored by epriestley on Jul 26 2016, 6:23 PM.
Tags
None
Referenced Files
F14059532: D16327.diff
Sun, Nov 17, 8:07 PM
F14048099: D16327.diff
Thu, Nov 14, 6:45 AM
F14041321: D16327.id.diff
Mon, Nov 11, 5:35 PM
F14034442: D16327.diff
Sun, Nov 10, 12:20 AM
F14021934: D16327.diff
Wed, Nov 6, 2:04 PM
Unknown Object (File)
Oct 13 2024, 7:00 PM
Unknown Object (File)
Oct 2 2024, 4:40 AM
Unknown Object (File)
Sep 12 2024, 8:37 AM
Subscribers
None

Details

Summary

Ref T11326. When an event is all-day, hide the time controls for the start/end dates. These aren't used and aren't helpful/useful.

This got a little more complicated than it used to be because EditEngine forms may have only some of these controls present.

Test Plan

Edited an all-day event; edited a normal event; swapped an event between normal and all-day.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Hide time controls when editing all-day Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.