Page MenuHomePhabricator

Hide time controls when editing all-day Calendar events
ClosedPublic

Authored by epriestley on Jul 26 2016, 6:23 PM.
Tags
None
Referenced Files
F15473792: D16327.diff
Sun, Apr 6, 1:47 AM
F15463103: D16327.id39265.diff
Tue, Apr 1, 8:18 PM
F15455440: D16327.diff
Sun, Mar 30, 12:22 AM
F15454598: D16327.id39256.diff
Sat, Mar 29, 7:15 PM
F15441765: D16327.id.diff
Wed, Mar 26, 7:46 PM
F15436411: D16327.diff
Tue, Mar 25, 1:59 PM
F15432855: D16327.id39256.diff
Mon, Mar 24, 7:58 PM
F15432554: D16327.id.diff
Mon, Mar 24, 6:33 PM
Subscribers
None

Details

Summary

Ref T11326. When an event is all-day, hide the time controls for the start/end dates. These aren't used and aren't helpful/useful.

This got a little more complicated than it used to be because EditEngine forms may have only some of these controls present.

Test Plan

Edited an all-day event; edited a normal event; swapped an event between normal and all-day.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Hide time controls when editing all-day Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.