Page MenuHomePhabricator

Hide time controls when editing all-day Calendar events
ClosedPublic

Authored by epriestley on Jul 26 2016, 6:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 29, 9:56 PM
Unknown Object (File)
Wed, Jul 8, 11:57 PM
Unknown Object (File)
Jul 3 2026, 3:34 AM
Unknown Object (File)
Jun 26 2026, 7:10 PM
Unknown Object (File)
Jun 26 2026, 7:10 PM
Unknown Object (File)
Jun 22 2026, 8:15 PM
Unknown Object (File)
Jan 11 2026, 12:49 AM
Unknown Object (File)
Jan 10 2026, 7:44 PM
Subscribers
None

Details

Summary

Ref T11326. When an event is all-day, hide the time controls for the start/end dates. These aren't used and aren't helpful/useful.

This got a little more complicated than it used to be because EditEngine forms may have only some of these controls present.

Test Plan

Edited an all-day event; edited a normal event; swapped an event between normal and all-day.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Hide time controls when editing all-day Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.