Page MenuHomePhabricator

Hide time controls when editing all-day Calendar events
ClosedPublic

Authored by epriestley on Jul 26 2016, 6:23 PM.
Tags
None
Referenced Files
F13131272: D16327.diff
Wed, May 1, 3:27 PM
Unknown Object (File)
Thu, Apr 25, 3:20 AM
Unknown Object (File)
Mon, Apr 22, 1:58 AM
Unknown Object (File)
Fri, Apr 19, 7:30 PM
Unknown Object (File)
Fri, Apr 19, 5:07 PM
Unknown Object (File)
Thu, Apr 11, 10:41 AM
Unknown Object (File)
Sat, Apr 6, 1:39 AM
Unknown Object (File)
Wed, Apr 3, 1:16 AM
Subscribers
None

Details

Summary

Ref T11326. When an event is all-day, hide the time controls for the start/end dates. These aren't used and aren't helpful/useful.

This got a little more complicated than it used to be because EditEngine forms may have only some of these controls present.

Test Plan

Edited an all-day event; edited a normal event; swapped an event between normal and all-day.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13132
Build 16801: Run Core Tests
Build 16800: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Hide time controls when editing all-day Calendar events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2016, 7:00 PM
This revision was automatically updated to reflect the committed changes.