Differential D16325

Use numeric input control for TOTP factor entry
ClosedPublic
Actions

Authored by fooishbar on Jul 26 2016, 10:26 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T11365: TOTP challenge entry not marked numeric-only on mobile

Commits

rP29d6e5fd4bae: Use numeric input control for TOTP factor entry

Summary

Finishes fixing T11365. rP28199bcb48 added the new numeric entry
control and used it for TOTP setup, but missed the case of entering
a factor when TOTP was already set up.

Test Plan

Observe behaviour of TOTP setup and subsequent factor entry
in iOS browser, make sure they're consistent.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fooishbar updated this revision to Diff 39252.Jul 26 2016, 10:26 AM

fooishbar retitled this revision from to Use numeric input control for TOTP factor entry.

fooishbar edited the test plan for this revision. (Show Details)

fooishbar added a task: T11365: TOTP challenge entry not marked numeric-only on mobile.

fooishbar updated this object.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 26 2016, 10:26 AM

Herald added a subscriber: epriestley. · View Herald Transcript

fooishbar mentioned this in T11365: TOTP challenge entry not marked numeric-only on mobile.Jul 26 2016, 10:28 AM

Oops, thanks!

This revision is now accepted and ready to land.Jul 26 2016, 11:46 AM

Closed by commit rP29d6e5fd4bae: Use numeric input control for TOTP factor entry (authored by fooishbar, committed by epriestley). · Explain WhyJul 26 2016, 11:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

factor/

PhabricatorTOTPAuthFactor.php

2 lines

Diff 39253

View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Use numeric input control for TOTP factor entryClosedPublicActions