Page MenuHomePhabricator

For now, hard limit task graph at 100 nodes
ClosedPublic

Authored by epriestley on Jul 14 2016, 4:10 AM.
Tags
None
Referenced Files
F14008631: D16295.id39191.diff
Wed, Oct 30, 2:42 AM
F13967507: D16295.diff
Oct 16 2024, 2:03 PM
F13959235: D16295.id39192.diff
Oct 14 2024, 6:24 PM
Unknown Object (File)
Oct 13 2024, 10:55 PM
Unknown Object (File)
Oct 11 2024, 6:14 PM
Unknown Object (File)
Oct 1 2024, 3:17 PM
Unknown Object (File)
Sep 24 2024, 10:44 PM
Unknown Object (File)
Sep 24 2024, 10:11 PM
Subscribers
None

Details

Summary

Ref T4788. One install has some particularly impressive task graphs which are thousands of nodes large.

The current graph is pretty broken in these cases. For now, just render a "too big to show" message. In the future, I'd plan to finesse this (e.g., show parents/children, show links to parents/children, etc).

Test Plan
  • Viewed a normal task.
  • Set limit to 3, viewed a task with graph size 6, saw an error message.
  • Viewed a revision stack graph (unaffected).

Diff Detail

Repository
rP Phabricator
Branch
glimit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13071
Build 16707: Run Core Tests
Build 16706: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to For now, hard limit task graph at 100 nodes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 14 2016, 4:12 AM
This revision was automatically updated to reflect the committed changes.