Differential D16284

Fix some EditEngine issues with rendering "invite" transactions
ClosedPublic
Actions

Authored by epriestley on Jul 12 2016, 8:23 PM.

Details

Reviewers

chad

Maniphest Tasks

T9275: Move Calendar to EditEngine

Commits

rP46cf1894134f: Fix some EditEngine issues with rendering "invite" transactions

Summary

Ref T9275. We were rendering too many transactions and/or over-rendering invitees.

Clean this logic up a bit:

List all before/after invitees.
Simplify the lists before rendering.

Test Plan

Viewed an event, edited invitees, got sensible human-readable transactions.

Diff Detail

Repository

rP Phabricator

Branch

calendar10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13038
Build 16662: Run Core Tests
Build 16661: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39158.Jul 12 2016, 8:23 PM

epriestley retitled this revision from to Fix some EditEngine issues with rendering "invite" transactions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9275: Move Calendar to EditEngine.

chad accepted this revision.Jul 12 2016, 10:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 12 2016, 10:09 PM

Closed by commit rP46cf1894134f: Fix some EditEngine issues with rendering "invite" transactions (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

editor/

PhabricatorCalendarEventEditor.php

2 lines

storage/

PhabricatorCalendarEventTransaction.php

28 lines

Diff 39158

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php