Page MenuHomePhabricator

Simplify the TYPE_INVITE Calendar Event transaction for EditEngine
ClosedPublic

Authored by epriestley on Jul 12 2016, 4:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 11, 9:56 AM
Unknown Object (File)
Jul 16 2022, 11:26 PM
Unknown Object (File)
Jul 15 2022, 4:36 PM
Unknown Object (File)
Jul 15 2022, 4:35 PM
Unknown Object (File)
Jul 4 2022, 3:14 AM
Unknown Object (File)
Jun 21 2022, 7:27 AM
Unknown Object (File)
Jun 8 2022, 2:22 AM
Unknown Object (File)
May 31 2022, 5:46 PM
Subscribers
None

Details

Summary

Ref T9275. Now that TYPE_ACCEPT and TYPE_DECLINE have been separated out, we can simplify TYPE_INVITE.

This now just takes a list of invited PHIDs, uninvites ones that were removed and invites ones that were added. This is simpler, lets more logic live in the Editor, and makes EditEngine/API access easier.

Test Plan

Created events, added and removed invitees. Used comment stacked action and "pro" editor to adjust invitees.

Diff Detail

Repository
rP Phabricator
Branch
calendar6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13032
Build 16652: Run Core Tests
Build 16651: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Simplify the TYPE_INVITE Calendar Event transaction for EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2016, 5:37 PM
This revision was automatically updated to reflect the committed changes.