Page MenuHomePhabricator
Differential D16280

Simplify the TYPE_INVITE Calendar Event transaction for EditEngine
ClosedPublic
Actions

Authored by epriestley on Jul 12 2016, 4:08 PM.
Tags
None
Referenced Files
F13061719: D16280.id.diff
Fri, Apr 19, 7:53 PM
F13061097: D16280.diff
Fri, Apr 19, 6:52 PM
F13059943: D16280.diff
Fri, Apr 19, 5:03 PM
F13048870: D16280.id39167.diff
Thu, Apr 18, 11:20 PM
Unknown Object (File)
Thu, Apr 11, 10:51 AM
Unknown Object (File)
Mon, Apr 8, 8:41 AM
Unknown Object (File)
Tue, Mar 26, 6:02 AM
Unknown Object (File)
Feb 19 2024, 8:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9275: Move Calendar to EditEngine
Commits
rPeebaf583421b: Simplify the TYPE_INVITE Calendar Event transaction for EditEngine
Summary

Ref T9275. Now that TYPE_ACCEPT and TYPE_DECLINE have been separated out, we can simplify TYPE_INVITE.

This now just takes a list of invited PHIDs, uninvites ones that were removed and invites ones that were added. This is simpler, lets more logic live in the Editor, and makes EditEngine/API access easier.

Test Plan

Created events, added and removed invitees. Used comment stacked action and "pro" editor to adjust invitees.

Diff Detail

Repository
rP Phabricator
Branch
calendar6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13032
Build 16652: Run Core Tests
Build 16651: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39153.Jul 12 2016, 4:08 PM
epriestley retitled this revision from to Simplify the TYPE_INVITE Calendar Event transaction for EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9275: Move Calendar to EditEngine.
chad accepted this revision.Jul 12 2016, 5:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 12 2016, 5:37 PM
Closed by commit rPeebaf583421b: Simplify the TYPE_INVITE Calendar Event transaction for EditEngine (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39153

View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEditEngine.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility