Differential D16272

Create separate "Accept" and "Decline" transactions for Calendar
ClosedPublic
Actions

Authored by epriestley on Jul 11 2016, 10:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T9275: Move Calendar to EditEngine

Commits

rP3a09bb577e0a: Create separate "Accept" and "Decline" transactions for Calendar

Summary

Ref T9275. Currently, there's a single "invite" transaction type for managing Calendar invites, and it takes a map of invitees to status.

This isn't great for EditEngine or API access, since it lets you set anyone else to any status and we can't reuse as much code as we can with a simpler API.

Make "Accept" and "Decline" separate actions which affect the actor's invite, so "invite" can be a simpler transaction which just invites or uninvites people.

Test Plan

Joined/accepted/declined an event invitation.
Edited event invitees.

Diff Detail

Repository

rP Phabricator

Branch

calendar4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13023
Build 16640: Run Core Tests
Build 16639: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39144.Jul 11 2016, 10:16 PM

epriestley retitled this revision from to Create separate "Accept" and "Decline" transcations for Calendar.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9275: Move Calendar to EditEngine.

epriestley retitled this revision from Create separate "Accept" and "Decline" transcations for Calendar to Create separate "Accept" and "Decline" transactions for Calendar.Jul 11 2016, 10:28 PM

chad accepted this revision.Jul 11 2016, 10:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 11 2016, 10:32 PM

Closed by commit rP3a09bb577e0a: Create separate "Accept" and "Decline" transactions for Calendar (authored by epriestley, committed by epriestley). · Explain WhyJul 13 2016, 2:42 PM

This revision was automatically updated to reflect the committed changes.