Page MenuHomePhabricator
Differential D16255

Add a strong hint about importing or observing repositories to repository creation
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 12:49 PM.
Tags
None
Referenced Files
F18087955: D16255.id39097.diff
Wed, Aug 6, 6:17 AM
F18053921: D16255.id39106.diff
Mon, Aug 4, 5:50 AM
F18047286: D16255.id.diff
Sun, Aug 3, 11:38 AM
F18039714: D16255.diff
Sun, Aug 3, 3:46 AM
F18009747: D16255.diff
Sat, Aug 2, 3:35 PM
F17946340: D16255.id39106.diff
Thu, Jul 31, 2:14 PM
F17930447: D16255.diff
Wed, Jul 30, 6:02 PM
Unknown Object (File)
May 31 2025, 9:02 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11278: It's confusing to figure out in the UI how to import a repository now
Commits
rP5c8dabdf8034: Add a strong hint about importing or observing repositories to repository…
Summary

Fixes T11278. Also mention svnsync, since we have some evidence that it works.

Test Plan

Screen Shot 2016-07-08 at 5.48.31 AM.png (1×1 px, 141 KB)

Diff Detail

Repository
rP Phabricator
Branch
import1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12973
Build 16567: Run Core Tests
Build 16566: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39097.Jul 8 2016, 12:49 PM
epriestley retitled this revision from to Add a strong hint about importing or observing repositories to repository creation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11278: It's confusing to figure out in the UI how to import a repository now.
chad requested changes to this revision.Jul 8 2016, 2:36 PM
chad edited edge metadata.

Maybe remove the green? Feels unusual to me.

This revision now requires changes to proceed.Jul 8 2016, 2:36 PM
chad accepted this revision.Jul 8 2016, 2:38 PM
chad edited edge metadata.

derp

This revision is now accepted and ready to land.Jul 8 2016, 2:38 PM
epriestley added a comment.Jul 8 2016, 2:39 PM

Without the green I was a little worried that the biggest / most obvious button takes you away from the workflow instead of moving you forward, but I can nuke it and we can see how things go.

epriestley updated this revision to Diff 39106.Jul 8 2016, 2:42 PM
epriestley edited edge metadata.
  • No green.
Closed by commit rP5c8dabdf8034: Add a strong hint about importing or observing repositories to repository… (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2016, 2:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
24 lines
docs/
user/
userguide/
68 lines
10 lines

Diff 39097

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

Loading...
View Options

src/docs/user/userguide/diffusion_existing.diviner

Loading...
View Options

src/docs/user/userguide/diffusion_uris.diviner

Loading...
Phabricator · Built by Phacility