Page MenuHomePhabricator

Fix a bad getURI() call in Profile Panel handle construction
ClosedPublic

Authored by epriestley on Jul 7 2016, 9:53 PM.

Details

Summary

Fixes T11285. We can end up loading panel handles while processing edits (e.g., disabling menu items on a project). We probably started loading these after the modular transaction changes in T9789, which load the handle for the transaction object unconditionally.

The handles aren't too useful, but they currently fail to load/build because panels don't have a URI. We could give them some sort of method here, but just nuke it for now since they don't appear anywhere and this unclogs the daemon queue.

Test Plan
  • Disabled a menu item on a project.
  • Ran publish task with bin/worker execute --id <id>.
  • Before patch: fatal on getURI() with stack trace similar to T11285.
  • After patch: clean execution.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 39088.Jul 7 2016, 9:53 PM
epriestley retitled this revision from to Fix a bad getURI() call in Profile Panel handle construction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
avivey accepted this revision.Jul 7 2016, 9:55 PM
avivey edited edge metadata.
This revision is now accepted and ready to land.Jul 7 2016, 9:55 PM
This revision was automatically updated to reflect the committed changes.