Differential D16240

Fix a Paste activate/archive status constant in rendering
ClosedPublic
Actions

Authored by epriestley on Jul 6 2016, 11:00 AM.

Details

Reviewers

chad

Maniphest Tasks

T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log

Commits

rP38c290a241b1: Fix a Paste activate/archive status constant in rendering

Summary

Fixes T11280. I extracted this at the last minute and got the constant flipped.

Test Plan

Archived, then activated a paste. Observed correct timeline stories/icons/etc.

Diff Detail

Repository

rP Phabricator

Branch

paste1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12942
Build 16518: Run Core Tests
Build 16517: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39066.Jul 6 2016, 11:00 AM

epriestley retitled this revision from to Fix a Paste activate/archive status constant in rendering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11280: Archiving/Activating Pastes reflects wrong in Recent Activity Log.

chad accepted this revision.Jul 6 2016, 2:07 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 6 2016, 2:07 PM

Closed by commit rP38c290a241b1: Fix a Paste activate/archive status constant in rendering (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2016, 2:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

xaction/

PhabricatorPasteStatusTransaction.php

2 lines

Diff 39066

View Options

src/applications/paste/xaction/PhabricatorPasteStatusTransaction.php

Fix a Paste activate/archive status constant in renderingClosedPublicActions