Differential D16203

When using the "Close as Duplicate" relationship action, limit the UI to 1 task
ClosedPublic
Actions

Authored by epriestley on Jun 30 2016, 6:50 PM.

Tags

None

Referenced Files

	F14496374: D16203.diff
	Fri, Jan 3, 2:00 PM

	Unknown Object (File)
	Fri, Dec 20, 6:05 PM

	Unknown Object (File)
	Tue, Dec 17, 9:26 AM

	Unknown Object (File)
	Fri, Dec 13, 12:21 AM

	Unknown Object (File)
	Tue, Dec 10, 5:39 AM

	Unknown Object (File)
	Nov 28 2024, 1:43 AM

	Unknown Object (File)
	Nov 18 2024, 8:43 PM

	Unknown Object (File)
	Oct 30 2024, 2:42 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4788: Allow "Edit Dependencies" both ways (blocking and depending)

Commits

rP7a315780b4fe: When using the "Close as Duplicate" relationship action, limit the UI to 1 task

Summary

Ref T4788. When closing a task as a duplicate of another task, you can only select one task, since it doesn't really make sense to merge one task into several other tasks (this operation is possible, but probably not what anyone ever wants to do, I think?).

Make the UI understand this: after you select a task, disable all of the "select" buttons in the UI to make this clear.

Test Plan

Used "Close as Duplicate", only allowed to select 1 task.
Used other editors like "Merge Duplicates In", allowed to select lots of tasks.

Diff Detail

Repository

Branch

attach6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12847
Build 16372: Run Core Tests
Build 16371: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38970.Jun 30 2016, 6:50 PM

epriestley retitled this revision from to When using the "Close as Duplicate" relationship action, limit the UI to 1 task.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4788: Allow "Edit Dependencies" both ways (blocking and depending).

chad accepted this revision.Jun 30 2016, 7:21 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2016, 7:21 PM

Closed by commit rP7a315780b4fe: When using the "Close as Duplicate" relationship action, limit the UI to 1 task (authored by epriestley, committed by epriestley). · Explain WhyJun 30 2016, 8:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

18 lines

src/

applications/

maniphest/

relationship/

ManiphestTaskCloseAsDuplicateRelationship.php

13 lines

search/

controller/

PhabricatorSearchRelationshipController.php

13 lines

relationship/

PhabricatorObjectRelationship.php

4 lines

view/

control/

PhabricatorObjectSelectorDialog.php

13 lines

webroot/

rsrc/

js/

core/

behavior-object-selector.js

120 lines

Diff 38970

resources/celerity/map.php

Loading...

src/applications/maniphest/relationship/ManiphestTaskCloseAsDuplicateRelationship.php

Loading...

src/applications/search/controller/PhabricatorSearchRelationshipController.php

Loading...

src/applications/search/relationship/PhabricatorObjectRelationship.php

Loading...

src/view/control/PhabricatorObjectSelectorDialog.php

Loading...

webroot/rsrc/js/core/behavior-object-selector.js

Loading...