Page MenuHomePhabricator
Differential D16193

Convert all standard relationship-editing actions to modern Relationships code
ClosedPublic
Actions

Authored by epriestley on Jun 29 2016, 1:27 PM.
Tags
None
Referenced Files
F13106350: D16193.diff
Sat, Apr 27, 7:38 PM
Unknown Object (File)
Wed, Apr 24, 10:48 PM
Unknown Object (File)
Fri, Apr 19, 4:58 PM
Unknown Object (File)
Thu, Apr 11, 7:42 AM
Unknown Object (File)
Wed, Apr 10, 1:57 AM
Unknown Object (File)
Thu, Apr 4, 3:07 PM
Unknown Object (File)
Wed, Apr 3, 7:09 PM
Unknown Object (File)
Fri, Mar 29, 11:06 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4788: Allow "Edit Dependencies" both ways (blocking and depending)
Commits
rPdc9283b85d71: Convert all standard relationship-editing actions to modern Relationships code
Summary

Ref T4788. This moves everything except "merge" to the new code.

Test Plan
  • Edited relationships in Differential, Diffusion, and Pholio.
  • Uninstalled Pholio, made sure "Edit Mocks..." actions vanished.

Diff Detail

Repository
rP Phabricator
Branch
attach2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12829
Build 16344: Run Core Tests
Build 16343: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38952.Jun 29 2016, 1:27 PM
epriestley retitled this revision from to Convert all standard relationship-editing actions to modern Relationships code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4788: Allow "Edit Dependencies" both ways (blocking and depending).
chad accepted this revision.Jun 29 2016, 5:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2016, 5:20 PM
Closed by commit rPdc9283b85d71: Convert all standard relationship-editing actions to modern Relationships code (authored by epriestley, committed by epriestley). · Explain WhyJun 29 2016, 6:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38952

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialChildRevisionsField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialDependenciesField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialDependsOnField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialParentRevisionsField.php

Loading...
View Options

src/applications/differential/relationships/DifferentialRevisionHasChildRelationship.php

Loading...
View Options

src/applications/differential/relationships/DifferentialRevisionHasCommitRelationship.php

Loading...
View Options

src/applications/differential/relationships/DifferentialRevisionHasParentRelationship.php

Loading...
View Options

src/applications/differential/relationships/DifferentialRevisionHasTaskRelationship.php

Loading...
View Options

src/applications/differential/relationships/DifferentialRevisionRelationship.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/relationships/DiffusionCommitHasRevisionRelationship.php

Loading...
View Options

src/applications/diffusion/relationships/DiffusionCommitHasTaskRelationship.php

Loading...
View Options

src/applications/diffusion/relationships/DiffusionCommitRelationship.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
View Options

src/applications/pholio/relationships/PholioMockHasTaskRelationship.php

Loading...
View Options

src/applications/pholio/relationships/PholioMockRelationship.php

Loading...
View Options

src/applications/search/relationship/DifferentialRevisionRelationshipSource.php

Loading...
View Options

src/applications/search/relationship/DiffusionCommitRelationshipSource.php

Loading...
View Options

src/applications/search/relationship/ManiphestTaskRelationshipSource.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationship.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationshipList.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationshipSource.php

Loading...
View Options

src/applications/search/relationship/PholioMockRelationshipSource.php

Loading...
Phabricator · Built by Phacility