Page MenuHomePhabricator
Differential D16192

Better 404 for Phame
ClosedPublic
Actions

Authored by chad on Jun 29 2016, 3:18 AM.
Tags
None
Referenced Files
F18819942: D16192.diff
Wed, Oct 22, 11:18 AM
F18759302: D16192.id.diff
Mon, Oct 6, 3:00 AM
F18648843: D16192.diff
Sep 20 2025, 5:26 PM
F18632487: D16192.id38949.diff
Sep 16 2025, 6:02 PM
F18182828: D16192.id38951.diff
Aug 16 2025, 10:22 AM
F18174479: D16192.id38949.diff
Aug 15 2025, 8:28 PM
F18154831: D16192.diff
Aug 14 2025, 8:41 PM
F18046033: D16192.diff
Aug 3 2025, 10:15 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP2b76785a13df: Better 404 for Phame
Summary

"Fixes" fatals on phacility.com blog. If post_id is either 0 or any other integer not in the blog system, show a normal Phame 404 with crumbs.

Test Plan

http://local.blog.phacility.com/post/0/last_published/, http://local.blog.phacility.com/post/999999/last_published/

Diff Detail

Repository
rP Phabricator
Branch
phame-500 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12827
Build 16341: Run Core Tests
Build 16340: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38949.Jun 29 2016, 3:18 AM
chad retitled this revision from to Better 404 for Phame.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJun 29 2016, 3:18 AM
epriestley accepted this revision.Jun 29 2016, 4:33 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2016, 4:33 AM
Closed by commit rP2b76785a13df: Better 404 for Phame (authored by chad, committed by chad). · Explain WhyJun 29 2016, 4:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
controller/
4 lines

Diff 38949

View Options

src/applications/phame/controller/PhameLiveController.php

Loading...
Phabricator · Built by Phacility