Paths

Table of Contentst

Better 404 for Phame
ClosedPublic
Actions

Authored by chad on Jun 29 2016, 3:18 AM.

Tags

None

Referenced Files

	F19103380: D16192.id.diff
	Fri, Dec 5, 9:58 AM

	F19070478: D16192.id38949.diff
	Sun, Nov 30, 5:10 PM

	F19039944: D16192.id.diff
	Wed, Nov 26, 10:27 AM

	F19008138: D16192.id38949.diff
	Fri, Nov 21, 9:35 PM

	F18993452: D16192.diff
	Wed, Nov 19, 8:02 AM

	F18975871: D16192.id38949.diff
	Sun, Nov 16, 10:27 AM

	F18870298: D16192.id.diff
	Nov 4 2025, 4:30 PM

	F18866505: D16192.diff
	Nov 3 2025, 5:31 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP2b76785a13df: Better 404 for Phame

Summary

"Fixes" fatals on phacility.com blog. If post_id is either 0 or any other integer not in the blog system, show a normal Phame 404 with crumbs.

Test Plan

http://local.blog.phacility.com/post/0/last_published/, http://local.blog.phacility.com/post/999999/last_published/

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 38949.Jun 29 2016, 3:18 AM

chad retitled this revision from to Better 404 for Phame.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 29 2016, 3:18 AM

epriestley accepted this revision.Jun 29 2016, 4:33 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 29 2016, 4:33 AM

Closed by commit rP2b76785a13df: Better 404 for Phame (authored by chad, committed by chad). · Explain WhyJun 29 2016, 4:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameLiveController.php

4 lines

Diff 38951

View Options

src/applications/phame/controller/PhameLiveController.php

Better 404 for PhameClosedPublicActions