Differential D16185

Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels
ClosedPublic
Actions

Authored by epriestley on Jun 28 2016, 9:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T11223: 404 site after Terminate Conduit API key

Commits

rPec8581ab629e: Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels

Summary

Fixes T11223. I missed a few of these; most of them kept working anyway because we have redirects in place, but make them a bit more modern/not-hard-coded.

Test Plan

Generated and revoked API tokens for myself.
Generated and revoked API tokens for bots.
Revoked temporary tokens for myself.
Clicked the link to the API tokens panel from the Conduit console.
Clicked all the cancel buttons in all the dialogs, too.

In all cases, everything now points at the correct URIs. Previously, some things pointed at the wrong URIs (mostly dealing with stuff for bots).

Diff Detail

Repository

rP Phabricator

Branch

paneluri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12814
Build 16323: Run Core Tests
Build 16322: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38935.Jun 28 2016, 9:26 PM

epriestley retitled this revision from to Clean up redirect URIs for "Temporary Toekns" and "API Tokens" settings panels.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11223: 404 site after Terminate Conduit API key.

chad accepted this revision.Jun 28 2016, 9:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 28 2016, 9:26 PM

epriestley retitled this revision from Clean up redirect URIs for "Temporary Toekns" and "API Tokens" settings panels to Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels.Jun 28 2016, 9:49 PM

epriestley edited edge metadata.

Closed by commit rPec8581ab629e: Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels (authored by epriestley, committed by epriestley). · Explain WhyJun 28 2016, 9:51 PM

This revision was automatically updated to reflect the committed changes.