Page MenuHomePhabricator

Censor credentials with "********" instead of "xxxxx"
ClosedPublic

Authored by epriestley on Jun 27 2016, 2:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 3, 10:38 PM
Unknown Object (File)
Tue, May 27, 11:17 AM
Unknown Object (File)
Fri, May 9, 10:59 PM
Unknown Object (File)
Apr 26 2025, 10:42 AM
Unknown Object (File)
Apr 13 2025, 11:53 AM
Unknown Object (File)
Apr 12 2025, 5:57 PM
Unknown Object (File)
Apr 9 2025, 11:12 PM
Unknown Object (File)
Apr 8 2025, 10:14 PM
Subscribers
None

Details

Summary

Ref T10982. There, and in other cases, it isn't obvious to users that we're censoring credentials when they see censored commands. Try using "****" instead of "xxxxx" to hopefully make it more clear.

Test Plan
  • Ran unit tests.
  • Ran repository pull --trace, saw this output:
>>> [20] <exec> $ git clone --bare -- '********' '/Users/epriestley/dev/core/repo/local/55'
<<< [20] <exec> 3,998,331 us

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Censor credentials with "********" instead of "xxxxx".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2016, 3:16 PM
This revision was automatically updated to reflect the committed changes.